Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract dev script for running lintian #1792

Merged
merged 11 commits into from
May 15, 2024
Merged

Conversation

jotaen4tinypilot
Copy link
Contributor

@jotaen4tinypilot jotaen4tinypilot commented Apr 25, 2024

Related #1716. Stacked on #1791.

This PR pulls out the inlined lintian invocation to its own dev script.

I had to apply one fix, because shellcheck complained about <(ls *.deb), which should be <(ls -- *.deb).
Review on CodeApprove

Base automatically changed from dev-scripts/check to master April 26, 2024 13:38
jotaen added 4 commits April 26, 2024 15:39
# Conflicts:
#	.circleci/config.yml
#	dev-scripts/check-bash
This reverts commit 4623dc9, reversing
changes made to 1ca0417.
@jotaen4tinypilot
Copy link
Contributor Author

(Sorry, I screwed up the merge from master – it’s fixed now.)

Copy link
Contributor

@jdeanwallace jdeanwallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated comment from CodeApprove ➜

Approved on CodeApprove
✔️ Approved


👀 @jotaen4tinypilot it's your turn please take a look

@jotaen4tinypilot jotaen4tinypilot merged commit d3fb5b1 into master May 15, 2024
13 checks passed
@jotaen4tinypilot jotaen4tinypilot deleted the dev-scripts/debian branch May 15, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants