Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hostname scripts are incompatible with Raspberry Pi OS Bookworm #1679

Closed
Tracked by #1668
cghague opened this issue Nov 8, 2023 · 1 comment · Fixed by #1803
Closed
Tracked by #1668

Hostname scripts are incompatible with Raspberry Pi OS Bookworm #1679

cghague opened this issue Nov 8, 2023 · 1 comment · Fixed by #1803
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@cghague
Copy link
Contributor

cghague commented Nov 8, 2023

Related #1668

Our hostname scripts make changes to /etc/hostname directly, which is no longer sufficient nor supported on Raspberry Pi OS Bookworm. We should instead use the hostnamectl tool, or we could call the do_hostname() function in raspi-config.

@cghague cghague added the bug Something isn't working label Nov 8, 2023
@mtlynch
Copy link
Contributor

mtlynch commented Nov 9, 2023

I'd like to go with hostnamectl if possible. raspi-config doesn't seem like they build with the expectation of third-parties depending on them.

@mtlynch mtlynch added the good first issue Good for newcomers label Jan 22, 2024
@db39 db39 self-assigned this May 27, 2024
@db39 db39 linked a pull request May 28, 2024 that will close this issue
db39 added a commit that referenced this issue Jun 27, 2024
Resolves #1679

This change updates the `change-hostname` script to use `hostnamectl`
instead of editing `/etc/hostname` directly.

<a data-ca-tag
href="https://codeapprove.com/pr/tiny-pilot/tinypilot/1803"><img
src="https://codeapprove.com/external/github-tag-allbg.png" alt="Review
on CodeApprove" /></a>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants