Replace the public surface with exact arbitrary-precision numbers. - #40
Merged
Conversation
Three operations on the old surface routed through float and every comparison used PHP's string operators, so the library was not arbitrary precision past 53 bits. Nothing from 3.x is preserved: division returns a BigRational so it never rounds, rounding happens only where a scale and a mode are named, and the arithmetic runs on an integer engine that is bcmath when the extension is loaded and a pure PHP backend when it is not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three operations on the old surface routed through float and every comparison used PHP's string operators, so the library was not arbitrary precision past 53 bits. Nothing from 3.x is preserved: division returns a BigRational so it never rounds, rounding happens only where a scale and a mode are named, and the arithmetic runs on an integer engine that is bcmath when the extension is loaded and a pure PHP backend when it is not.