Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed missing pyi files in python wheel #882

Merged
merged 3 commits into from
Aug 18, 2023
Merged

fixed missing pyi files in python wheel #882

merged 3 commits into from
Aug 18, 2023

Conversation

Ovizro
Copy link
Contributor

@Ovizro Ovizro commented Aug 16, 2023

No description provided.

@or-else
Copy link
Contributor

or-else commented Aug 17, 2023

Could you please explain the use case which requires this change?

@Ovizro
Copy link
Contributor Author

Ovizro commented Aug 17, 2023

This is related to my last pull request #863. Before I tried to add the generation of the pyi file when the python module was generated, but when I tested the packaging of the python module, I found that the pyi file was not correctly packaged into the wheel. So I appended this change.

The core changes only exist in setup.py, where I append the pyi file in package data. I modified the module generation command in README.md to be consistent with the generation script. As for the .gitignore file, I would delete it if you don't want it there.

@or-else
Copy link
Contributor

or-else commented Aug 18, 2023

Yes, please remove .gitignore or move in to py_grpc. Thanks!

@or-else or-else merged commit 47cda76 into tinode:devel Aug 18, 2023
@or-else
Copy link
Contributor

or-else commented Aug 18, 2023

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants