-
Notifications
You must be signed in to change notification settings - Fork 58
Update hook kernel to 5.10.85 #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
markjacksonfishing
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this pr. Kindly sign the DCO
|
Looks like the kernel build passes but hook can't be built with linuxkit because it can't locate the necessary kernel container image. Is there an alternate registry that should be specified in I will also go back and do the DCO. |
thebsdbox
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
Once dco is sorted this should be good to go. |
Signed-off-by: Jon Polom <jon@subly.me>
Signed-off-by: Jon Polom <jon@subly.me>
…cessful test Signed-off-by: Jon Polom <jon@subly.me>
|
@thebsdbox DCO is complete. Commits are signed however github does not seem to recognize my gpg key for some reason that I will have to sort out later. |
|
Is this good to merge now? |
|
@thebsdbox and @markyjackson-taulia can this get merged? |
|
We will need to debug the failure. I am tied up for the rest of today but if no one looks by tomorrow morning, I will get it some eyes. |
|
Seems to fail when it can't find the hook-kernel image with |
|
@Mergifyio refresh |
|
Holy moly I can merge this! |
Description
This PR updates the hook kernel to 5.10.85 and could maybe close #90. Earlier 5.10.x kernel versions, such as 5.10.57 which was the previously released kernel for hook, seemed to have a bug in the
igcmodule that prevented certain NICs from functioning. Later kernel versions fixed this issue.We need to discuss longer term plans for supporting hook though. Hook had not seen a kernel update for many months, but meanwhile new hardware requiring support continues to come onto the market. We should formulate a plan for moving hook to the next LTS kernel which is 5.15 and also a release cadence as new kernels release upstream.
Why is this needed
Fixes: #90
How Has This Been Tested?
Note: this still needs to be run through the standard tinkerbell CI tests.
This has been tested with a single device (Minisforum HX90) as detailed in the initial issue. More thorough testing with a larger variety of hardware devices might be desirable.
After making the detailed changes, Hook and the kernel were built outside of CI on my development desktop. A test instance of the tinkerbell sandbox was setup using ansible and podman on the same workstation. After the example sandbox workflow was modified slightly to account for the presence of an nvme SSD in the HX90, the device was powered on and successfully imaged via hook and the example sandbox workflow. This resulted in the HX90 having a bootable Ubuntu Focal image installed.
How are existing users impacted? What migration steps/scripts do we need?
Users should only need to download and deploy the updated pre-built binaries for hook if they desire to upgrade. This upgrade is really not "mandatory" as prior versions of hook should continue to function just fine. Many users may opt to not upgrade unless they are encountering compatibility issues with the prior release of hook. The remaining work that needs to happen is on the project side to get these changes built and published for public consumption.
Checklist:
I have: