Adds retry instead of immediate failure #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
stephen-fox
reviewed
Nov 16, 2021
Signed-off-by: Dan Finneran <dan@thebsdbox.co.uk>
ScottGarman
force-pushed
the
dhcp-retry
branch
from
3947b83 to
412f468
Compare
stephen-fox
reviewed
Nov 16, 2021
stephen-fox
approved these changes
Nov 17, 2021
stephen-fox
left a comment
stephen-fox
left a comment
There was a problem hiding this comment.
We discussed the HTTP GET timeout as a team, and decided that the caller can deal with it because Go has an awesome concurrency model.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Instead of immediate failure, we now have a retry mechanism in the event DHCP is slow
Why is this needed
Instant failure happens if the network takes a little bit of time to come up.. this adds a retry and sleep etc.
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: