Skip to content

Conversation

@micahhausler
Copy link
Contributor

@micahhausler micahhausler commented Jun 16, 2021

Description

Linuxkit has removed the -disable-content-trust flag

Why is this needed

I couldn't get the previously used version of linuxkit to build.

How Has This Been Tested?

I built a hook image locally and booted a Tink worker with the latest version of linuxkit

How are existing users impacted? What migration steps/scripts do we need?

Users can use and build a with a newer version of linuxkit

Checklist:

I have:

  • updated the documentation and/or roadmap (if required): N/A
  • added unit or e2e tests: N/A
  • provided instructions on how to upgrade: N/A

@thebsdbox
Copy link
Contributor

@micahhausler Looks like the sha256 needs updating to -> 1hx5k0l9gniz9aj9li8dkiniqs77pyfcl979y75yqm3mynrdz9ca

@micahhausler
Copy link
Contributor Author

Not sure what the failure is. It looks like its missing an image?

linuxkit build -docker -pull -format kernel+initrd -name hook-x86_64 -dir out hook-ci.yaml
Extract kernel image: localhost:5000/tinkerbell/hook-kernel:5.10.11
Image localhost:5000/tinkerbell/hook-kernel:5.10.11 not found in local cache, pulling
time="2021-06-18T15:15:19Z" level=fatal msg="Failed to extract kernel image and tarball: Could not pull image localhost:5000/tinkerbell/hook-kernel:5.10.11: error getting manifest for trusted image localhost:5000/tinkerbell/hook-kernel:5.10.11: GET http://localhost:5000/v2/tinkerbell/hook-kernel/manifests/5.10.11: MANIFEST_UNKNOWN: manifest unknown; map[Tag:5.10.11]"

@micahhausler micahhausler force-pushed the linuxkit-flags branch 2 times, most recently from 0886521 to a9bd153 Compare June 22, 2021 17:25
* removed deprecated linuxkit flag from Makefile
* Added clean Make target
* Added build dirs to gitignore
* Fixed CI build

Signed-off-by: Micah Hausler <mhausler@amazon.com>
@micahhausler
Copy link
Contributor Author

So GH runs a merge before running CI, which was confusing the situation.

@thebsdbox I think #48 broke CI, but it should be doing the right thing now

@markjacksonfishing markjacksonfishing added the ready-to-merge Signal to Mergify to merge the PR. label Jun 22, 2021
@markjacksonfishing markjacksonfishing self-assigned this Jun 22, 2021
@markjacksonfishing markjacksonfishing merged commit 60d23af into tinkerbell:main Jun 22, 2021
@micahhausler micahhausler deleted the linuxkit-flags branch June 22, 2021 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-merge Signal to Mergify to merge the PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants