bootable: cleanups; config grub.cfg/extlinux.conf/cmdline.txt via environment during build #264
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
- so I don't keep spreading conditionals everywhere Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
- usage: `mv "${debug_dash_v[@]}" here there`
Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
- this reads variables and produces kernel command line for all bootables - it defaults to a bare `tinkerbell` hostname, but that can be overridden with `TINK_SERVER` var/param - `grpc_authority=tinkerbell:42113` - `syslog_host=tinkerbell` Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
- using `fill_array_bootable_tinkerbell_kernel_parameters()` Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
- using `fill_array_bootable_tinkerbell_kernel_parameters()` Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
- using `fill_array_bootable_tinkerbell_kernel_parameters()` Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
Signed-off-by: Ricardo Pardini <ricardo@pardini.net>
jacobweinstock
approved these changes
Apr 17, 2025
Member
|
@rpardini thanks for this! |
jacobweinstock
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bootable: cleanup logging; use bat/tree helpers
bootable: rpi: cleanup config.txt
bootable: rpi: cmdline.txt: handle tink-related kernel args
fill_array_bootable_tinkerbell_kernel_parameters()bootable: grub: grub.cfg: handle tink-related kernel args
fill_array_bootable_tinkerbell_kernel_parameters()bootable: u-boot: extlinux/boot.scr: handle tink-related kernel args
fill_array_bootable_tinkerbell_kernel_parameters()linuxkit: cleanup debug logging
bootable: introduce
fill_array_bootable_tinkerbell_kernel_parameters()tinkerbellhostname, but that can be overriddenwith
TINK_SERVERvar/paramgrpc_authority=tinkerbell:42113syslog_host=tinkerbellbuild: global debug helpers for coreutils mv/cp/etc
mv "${debug_dash_v[@]}" here therecommon: add helper
log_file_bat()bootable: add required argument handling
bootable: rockchip: add quartz64a board (Armbian edge kernel)