Skip to content

Conversation

@jacobweinstock
Copy link
Member

Description

This gets us persistent network interface naming.

@rpardini , you did a bunch of work creating images/hook-mdev/persistent-storage.sh, when/if you have some cycles, would you mind checking this out and verifying if you see the same functionality?

Why is this needed

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

This gets us persistent network interface naming.

Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
@rpardini
Copy link
Member

Tested, seems to work fine -- being an actual systemd container it does disk/by-id et al "correctly", which is was what I was trying to emulate in persistent-storage.sh, so win all around in my eyes.

The only downside is that the thing is quite large, including glibc and systemd etc amounting to around 116mb of stuff.
Only hook-docker is bigger at 215mb.

All that said I'd rather have this than the mdev prone-to-fail dance we had before -- and this opens up the path for a (fully) systemd-based thing in the future.

Thanks!

Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
@jacobweinstock
Copy link
Member Author

Thanks for reviewing and testing this, @rpardini ! Yeah, I tried to find a way to slim it down but couldn't find anything that worked. With the new Tink Agent supporting containerd we can move to that and get rid of Docker entirely from Hook. That should get us back all the space and more.

@jacobweinstock jacobweinstock requested a review from rpardini April 14, 2025 21:22
@jacobweinstock jacobweinstock merged commit 62730e3 into tinkerbell:main Apr 14, 2025
29 checks passed
@jacobweinstock jacobweinstock deleted the udev branch April 14, 2025 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants