Add a magic string for the ISO kernel cmdline: #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a 1024 character string that is used as a known string to match on when binary patching the Hook ISO. This means that a service needs to binary patch the Hook ISO that is built with the cmdline. In the Tinkerbell stack this is functionality that is being built into Smee. Signed-off-by: Jacob Weinstock <jakobweinstock@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds a 1024 character string that is used as a known string to match on when binary patching the Hook ISO. This means that a service needs to binary patch the Hook ISO that is built with the cmdline. In the Tinkerbell stack this is functionality that is being built into Smee. 1024 characters were chosen to allow for patching all the things that the
auto.ipxein Smee allows for currently. This include many things like, tink worker image, container registry info, proxies, and more.Why is this needed
Fixes: #
How Has This Been Tested?
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: