Add proxy support for hook-bootkit and hook-docker #162
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e proxy variables Signed-off-by: panktishah26 <shah.pankti2609@gmail.com>
panktishah26
force-pushed
the
hook-proxy-support
branch
from
84f1c71 to
873a88b
Compare
jacobweinstock
approved these changes
Feb 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for pulling docker images and specifically the tink-worker image via a proxy by configuring appropriate proxy variables via Boots.
Why is this needed
Currently a user cannot use a proxy to pull tink-worker and container images for workflows. This PR enables proxy support for this. A user will have to pass HTTP_PROXY, HTTPS_PROXY and NO_PROXY to Boots as cli args or environment variables. These values in Boots, extra kernel args, get populated in Hook's
/proc/cmdlinefile. hook-bootkit and hook-docker will pick up those variables and set them as an environment variables in order to pull tink-worker and workflow images from a proxy server.Fixes: #
How Has This Been Tested?
I have tested this changes by creating a cluster on baremetal machines using the proxy settings.
How are existing users impacted? What migration steps/scripts do we need?
No changes are required for existing user.
Checklist:
I have: