Skip to content

Add Cisco drivers #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2022
Merged

Add Cisco drivers #144

merged 1 commit into from
Oct 12, 2022

Conversation

@ptrivedi
Copy link
Contributor

@ptrivedi ptrivedi commented Oct 10, 2022

Description

Why is this needed

Fixes: #

How Has This Been Tested?

How are existing users impacted? What migration steps/scripts do we need?

Checklist:

I have:

  • updated the documentation and/or roadmap (if required)
  • added unit or e2e tests
  • provided instructions on how to upgrade

@jacobweinstock
Copy link
Member

jacobweinstock commented Oct 12, 2022

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Oct 12, 2022

update

☑️ Nothing to do

  • #commits-behind>0 [:pushpin: update requirement]
  • -closed [:pushpin: update requirement]

jacobweinstock
jacobweinstock previously approved these changes Oct 12, 2022
View reviewed changes
@jacobweinstock
Copy link
Member

jacobweinstock commented Oct 12, 2022

Hey @ptrivedi, looks like the validation check doesn't run for changes in kernel/ directory.

Would you mind, maybe, fixing this spelling mistake here, so that the validation check will run? I will open a issue for this validation check being required for kernel/ directory changes.

@jacobweinstock jacobweinstock mentioned this pull request Oct 12, 2022
Closed
@jacobweinstock
Copy link
Member

jacobweinstock commented Oct 12, 2022

issue #145 opened.

@ptrivedi
Copy link
Contributor Author

ptrivedi commented Oct 12, 2022

Hey @ptrivedi, looks like the validation check doesn't run for changes in kernel/ directory.

Would you mind, maybe, fixing this spelling mistake here, so that the validation check will run? I will open a issue for this validation check being required for kernel/ directory changes.

Sure thing

@ptrivedi
Add Cisco drivers
85f2cb3 
Signed-off-by: Pooja Trivedi <poojatrivedi@gmail.com>
@thebsdbox
Copy link
Contributor

thebsdbox commented Oct 12, 2022

Nice work!

thebsdbox
thebsdbox approved these changes Oct 12, 2022
View reviewed changes
Copy link
Contributor

@thebsdbox thebsdbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jacobweinstock jacobweinstock added the ready-to-merge Signal to Mergify to merge the PR. label Oct 12, 2022
@mergify mergify bot merged commit 024379b into tinkerbell:main Oct 12, 2022
@ptrivedi ptrivedi deleted the cisco-drivers branch October 13, 2022 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jacobweinstock jacobweinstock jacobweinstock left review comments

+1 more reviewer

@thebsdbox thebsdbox thebsdbox approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ready-to-merge Signal to Mergify to merge the PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ptrivedi @jacobweinstock @thebsdbox