Rework use of actions/upload-artifact #135
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The artificat ends up being named $name.zip the previous name (hook-$commit.tar.gz.zip) was weird, now its just hook-$commit.zip. Also use the correct paths to the per-arch boot files. Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>
ScottGarman
approved these changes
Jun 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Uses the correct path to the build files when passing them to upload-artifact so that the files are actually uploaded.
Why is this needed
Files weren't being uploaded.
How Has This Been Tested?
From my fork.
How are existing users impacted? What migration steps/scripts do we need?
They can fetch files built by official CI instead of being required to build locally.