Use better tags for bootkit and docker images #128
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmlb
force-pushed
the
better-image-versions
branch
from
3f93a09 to
afef1e7
Compare
By default we'll live with `latest` (instead of 0.0) but be able to specify any tag we want. The idea being we can provide the tag on pushes and set both latest and a per-commit sha-* tag (like all the other service images do). Signed-off-by: Manuel Mendez <github@i.m.mmlb.dev>
mmlb
force-pushed
the
better-image-versions
branch
from
afef1e7 to
4fef8ab
Compare
ScottGarman
approved these changes
May 18, 2022
Contributor
ScottGarman
left a comment
ScottGarman
left a comment
There was a problem hiding this comment.
This has been so needed! Thanks for tackling this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This will build and push images that can be tracked back to a git commit. This way we don't clobber 0.0 over and over. This also changes from 0.0 to the more common
latestin docker/containers land. I did this because hook doesn't do any kind of semver anyway so might as well drop the not-meaningful 0.0. When ever we do start tagging versions here we can get back to publishing semver tags (I'd like to see latest, vX, vX.Y too for main, not sure about vX.Y.Z, but thats for another day).Why is this needed
Helps me clean up the Makefile, and helps users to not always be fetching equivalent of
latest.How Has This Been Tested?
I've run the Makefile stuff locally, but will leave the GHA to GHA.
How are existing users impacted? What migration steps/scripts do we need?
Users will have to decide if they want to stay on
latestor choose a specific sha-$COMMIT and will need to choose when to bump the image version if they choose the latter. This is only temporary as we should start tagging stuff here soon.