Tink worker image pull retry #122
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptrivedi
force-pushed
the
tink-worker-image-pull-retry
branch
2 times, most recently
from
cce2cb3 to
c4da6b1
Compare
jacobweinstock
previously approved these changes
May 4, 2022
Member
jacobweinstock
left a comment
jacobweinstock
left a comment
There was a problem hiding this comment.
Thank you! seems reasonable and improved from what we have!
CC @thebsdbox , @tstromberg , @mmlb
mmlb
reviewed
May 4, 2022
ptrivedi
force-pushed
the
tink-worker-image-pull-retry
branch
from
c4da6b1 to
3af9d6f
Compare
|
Looks like it has been update now, might need a re-review. |
mmlb
reviewed
May 23, 2022
ptrivedi
force-pushed
the
tink-worker-image-pull-retry
branch
from
3af9d6f to
3b45f85
Compare
Contributor
Author
|
@mmlb: resolved comments |
mmlb
suggested changes
Jun 1, 2022
jacobweinstock
force-pushed
the
tink-worker-image-pull-retry
branch
from
3b45f85 to
8fbcec5
Compare
ptrivedi
force-pushed
the
tink-worker-image-pull-retry
branch
2 times, most recently
from
1f528f3 to
b8e5458
Compare
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
ptrivedi
force-pushed
the
tink-worker-image-pull-retry
branch
from
b8e5458 to
13aff01
Compare
jacobweinstock
requested changes
Sep 20, 2022
There could be races where linuxkit network or dns may not have been fully set up and functional yet and image pull fails because of that. Signed-off-by: Pooja Trivedi <tripooja@amazon.com>
ptrivedi
force-pushed
the
tink-worker-image-pull-retry
branch
from
13aff01 to
6a6ac91
Compare
jacobweinstock
approved these changes
Sep 20, 2022
Contributor
Author
|
@mmlb: do the honors please |
mmlb
approved these changes
Sep 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Image pull retry for tink-worker image
Why is this needed
There could be races where linuxkit network or dns may not have been
fully set up and functional yet and image pull fails because of that.
Fixes: #
Implement image pull retry loop for tink-worker image. This loop attempts an image pull every 5 seconds, upto 10 times
How Has This Been Tested?
Tested by re-running a full provisioning workflows on bare metal server and simulate image pull failures artificially to test out the retry logic.
How are existing users impacted? What migration steps/scripts do we need?
Checklist:
I have: