Making the project work inside the Windows platform #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rolftimmermans please review the PR, I don't know why the Reviewers doesn't allow me to set anyone. |
|
Looks fine, and tests still pass with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've removed the lock files because those aren't supposed to be commited to source control, and also udpated gitignore to a more Visual Studio template (from here https://github.com/github/gitignore/blob/master/VisualStudio.gitignore).
I've made some adjustments on the tests because of the "not wired" build platform as the user agent will depend on the platform the user is running the tests on.
Also made some adjustments on the project.json files (at least to work on Visual Studio 2015). VS 2017 will migrate those again to csproj, but an enhanced version.
I also tried the Itegration tests. I had to make some adjustement on the path of the example fle in order for us to run the tests well either on the dotnet cli and inside the unit testes explorer inside Visual Studio.