chore(ci): workflow to check mocks are kept updated (ChainSafe#2062)

* workflow to check mocks are updated

* Install mockery and mockgen

* Update outdated mocks

* Fix outdated test code

.github/workflows/mocks.yml

@@ -0,0 +1,29 @@
+name: Mocks check
+on:
+  pull_request:
+    branches:
+      - development
+    paths:
+      - .github/workflows/mocks.yml
+      - "**/*.go"
+
+jobs:
+  mocks-check:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v2
+
+      - uses: actions/setup-go@v2
+        with:
+          go-version: "^1.17"
+
+      - run: go install github.com/vektra/mockery/v2@v2.9.4
+
+      - run: go install github.com/golang/mock/mockgen@v1.6.0
+
+      - run: go generate -run "mockery" ./...
+
+      - run: go generate -run "mockgen" ./...
+
+      - name: mocks updated check
+        run: git diff --exit-code

dot/network/notifications_test.go

@@ -304,7 +304,10 @@ func Test_HandshakeTimeout(t *testing.T) {
 func TestCreateNotificationsMessageHandler_HandleTransaction(t *testing.T) {
 	basePath := utils.NewTestBasePath(t, "nodeA")
 	mockhandler := &MockTransactionHandler{}
-	mockhandler.On("HandleTransactionMessage", mock.AnythingOfType("*network.TransactionMessage")).Return(true, nil)
+	mockhandler.On("HandleTransactionMessage",
+		mock.AnythingOfType("peer.ID"),
+		mock.AnythingOfType("*network.TransactionMessage")).
+		Return(true, nil)
 	mockhandler.On("TransactionsCount").Return(0)
 	config := &Config{
 		BasePath:           basePath,

dot/network/service_test.go

@@ -71,7 +71,10 @@ func createTestService(t *testing.T, cfg *Config) (srvc *Service) {
 
 	if cfg.TransactionHandler == nil {
 		mocktxhandler := &MockTransactionHandler{}
-		mocktxhandler.On("HandleTransactionMessage", mock.AnythingOfType("*TransactionMessage")).Return(nil)
+		mocktxhandler.On("HandleTransactionMessage",
+			mock.AnythingOfType("peer.ID"),
+			mock.AnythingOfType("*TransactionMessage")).
+			Return(nil)
 		mocktxhandler.On("TransactionsCount").Return(0)
 		cfg.TransactionHandler = mocktxhandler
 	}

dot/network/test_helpers.go

@@ -60,7 +60,10 @@ func NewMockSyncer() *MockSyncer {
 // NewMockTransactionHandler create and return a network TransactionHandler interface
 func NewMockTransactionHandler() *MockTransactionHandler {
 	mocktxhandler := new(MockTransactionHandler)
-	mocktxhandler.On("HandleTransactionMessage", mock.AnythingOfType("*network.TransactionMessage")).Return(nil)
+	mocktxhandler.On("HandleTransactionMessage",
+		mock.AnythingOfType("peer.ID"),
+		mock.AnythingOfType("*network.TransactionMessage")).
+		Return(nil)
 	mocktxhandler.On("TransactionsCount").Return(0)
 	return mocktxhandler
 }

dot/network/transaction_test.go

@@ -28,7 +28,10 @@ func TestDecodeTransactionHandshake(t *testing.T) {
 func TestHandleTransactionMessage(t *testing.T) {
 	basePath := utils.NewTestBasePath(t, "nodeA")
 	mockhandler := &MockTransactionHandler{}
-	mockhandler.On("HandleTransactionMessage", mock.AnythingOfType("*network.TransactionMessage")).Return(true, nil)
+	mockhandler.On("HandleTransactionMessage",
+		mock.AnythingOfType("peer.ID"),
+		mock.AnythingOfType("*network.TransactionMessage")).
+		Return(true, nil)
 	mockhandler.On("TransactionsCount").Return(0)
 
 	config := &Config{
@@ -46,5 +49,6 @@ func TestHandleTransactionMessage(t *testing.T) {
 	}
 
 	s.handleTransactionMessage(peer.ID(""), msg)
-	mockhandler.AssertCalled(t, "HandleTransactionMessage", msg)
+	mockhandler.AssertCalled(t, "HandleTransactionMessage",
+		mock.AnythingOfType("peer.ID"), msg)
 }