-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gateware/ice40: add mux stage and direct register drive to LED block #167
Conversation
Update from master
Sync from master
mithro: please help me with style (especially CAPS where not appropriate) and the issue mentioned on irc. any suggestions on how to get migen to emit binary? Am seeing "ERROR: expected configuration string starting with '0b' for parameter 'RGB0_CURRENT' on cell 'SB_RGBA_DRV'" because my binary was evaluate to a decimal constant (.RGB0_CURRENT(2'd3). Thanks. |
Note that this is not register compatible with foboot impl, I opted for a separate mux register to make the bits align. I'm planning an emulation of this block for other platforms and want it to be for n leds so the mismatching bits don't work too well. |
I think you need an str in there somewhere. Poke me tomorrow when I'm not in a bar. :-) |
@TomKeddie It seems like the str fixed the issue? |
mithro: yes, thanks. I feel like I need to test this code more but am looking for a nod that this is what you intended and is moving in the right direction. Thanks. |
mithro: when you have a moment please give this a once over, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me but can't /actually/ tell without also have this for the other boards?
) | ||
|
||
self.comb += [If(self.mux.storage[0], led_drv[led_defs["R"]["SIGNAL_INDEX"]].eq(self.raw.storage[0])).Else(led_drv[led_defs["R"]["SIGNAL_INDEX"]].eq(pwm_src[0])), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Newline here.
Contains; * UP5K's SPRAM * LED hard IP.
Actually put it where ever the sram region is suppose to go.
…de litex-buildenv dir
…ex-buildenv into tomk_20190709_ice50led_enh
Can you rebase this on master? |
replaced by #180 |
As requested in im-tomu/foboot#20