Skip to content

Fix playlist import race condition on large libraries (#127)Import playlists issue #192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix playlist import race condition on large libraries (#127)Import playlists issue #192

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e96ef76
Fix playlist import race condition on large libraries (#127)
claude Nov 12, 2025
4cbe034
Refactor: Replace getSongsDirect() with proper cache synchronization
claude Nov 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion ...c/main/java/com/simplecityapps/localmediaprovider/local/repository/LocalSongRepository.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.flow.Flow
import kotlinx.coroutines.flow.SharingStarted
import kotlinx.coroutines.flow.StateFlow
import kotlinx.coroutines.flow.first
import kotlinx.coroutines.flow.flowOn
import kotlinx.coroutines.flow.map
import kotlinx.coroutines.flow.stateIn
Expand Down Expand Up @@ -73,7 +74,15 @@ class LocalSongRepository(
updates: List<Song>,
deletes: List<Song>,
mediaProviderType: MediaProviderType
): Triple<Int, Int, Int> = songDataDao.insertUpdateAndDelete(inserts.toSongData(mediaProviderType), updates.toSongDataUpdate(), deletes.toSongData(mediaProviderType))
): Triple<Int, Int, Int> {
val result = songDataDao.insertUpdateAndDelete(inserts.toSongData(mediaProviderType), updates.toSongDataUpdate(), deletes.toSongData(mediaProviderType))

// Wait for the StateFlow cache to synchronize with the database changes
// This ensures subsequent reads will see the updated data, preventing race conditions
songsRelay.first { it != null }

return result
}

override suspend fun incrementPlayCount(song: Song) {
Timber.v("Incrementing play count for song: ${song.name}")
Expand Down
Loading