This repository was archived by the owner on Apr 26, 2023. It is now read-only.
Properly reset list item height after animation#14
Merged
timroes merged 1 commit intotimroes:masterfrom Dec 22, 2013
cketti:reset_list_item_height
Merged
Properly reset list item height after animation#14timroes merged 1 commit intotimroes:masterfrom cketti:reset_list_item_height
timroes merged 1 commit intotimroes:masterfrom
cketti:reset_list_item_height
Conversation
Previously the list item height was reset to the pixel value it had before the dismiss animation started. This could lead to wrong results when wrap_content was used for the item height and the view was recycled for another list item. Now the layout height parameter is restored to its original value.
Contributor
Author
|
Hi. Is there anything I can do to help getting this merged? |
timroes
added a commit
that referenced
this pull request
Dec 22, 2013
Properly reset list item height after animation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the list item height was reset to the pixel value it had
before the dismiss animation started. This could lead to wrong results
when wrap_content was used for the item height and the view was recycled
for another list item.
Now the layout height parameter is restored to its original value.