Skip to content

Return meaningful error message #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 9, 2021
Merged

Return meaningful error message #1

merged 2 commits into from
Jul 9, 2021

Conversation

ducrot
Copy link
Contributor

@ducrot ducrot commented Jul 7, 2021

Any reason not returning a meaningful error message?

@ducrot
Return meaningful error message
5a39466 
Any reason not returning a meaningful error message?
@timostamm
Copy link
Owner

Nope.

I think this test case needs an update?

symfony-twirp-handler/tests/SymfonyTwirpHandler/TwirpHandlerTest.php

Line 153 in 8ebf157

$this->expectExceptionMessage('Internal service error');

@ducrot
Copy link
Contributor Author

ducrot commented Jul 9, 2021

Absolutely!

@timostamm timostamm merged commit a9fee5c into timostamm:master Jul 9, 2021
@timostamm
Copy link
Owner

Should be available in v0.0.4 on packagist.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ducrot @timostamm