Fix getting commits for a merge request originating from a (now deleted) fork #403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method used to use the merge request's source project (e.g. a fork) to get the commits. However this appears to be unnecessary and wrong with current GitLab versions at least 14.x, 15.x). In particular, this would fail hard when trying to get the commits after the source project was deleted. The commits of a merge request belong to the project of the merge request and not to any other project where they may have been developed in.
cpfeiffer
added a commit
to GEBIT/gitlab-github-proxy
that referenced
this pull request
Oct 17, 2022
See timols/java-gitlab-api#403 for the same fix upstream.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method used to use the merge request's source project (e.g. a fork) to get the commits. However this appears to be unnecessary and wrong with current GitLab versions at least 14.x, 15.x).
In particular, this would fail hard when trying to get the commits after the source project was deleted.
The commits of a merge request belong to the project of the merge request and not to any other project where they may have been developed in.
This now works both for fork (still available) and fork (deleted), as well as merge requests from within the same project (no fork),