Skip to content

Conversation

mjdetullio
Copy link
Contributor

The latest versions of GitLab use an internal ID for project specific numbering. Required for timols/jenkins-gitlab-merge-request-builder-plugin/pull/33

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any chance we could rename this to _internalId? When I first saw it I immediately wondered what an iid was until I realized you meant internal id.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I named it as is to stay consistent with GitLab's naming, but if you still want I can update when I get a chance

timols added a commit that referenced this pull request Dec 7, 2013
Add support for MR internal ID
@timols timols merged commit 983e34f into timols:master Dec 7, 2013
@mjdetullio mjdetullio deleted the feature/iid branch December 7, 2013 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants