due date deserialization fix #351
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timols
requested changes
Aug 13, 2019
build.gradle
Outdated
| compile(group: 'org.slf4j', name: 'slf4j-api', version: '1.8.0-beta2') | ||
| compile(group: "com.fasterxml.jackson.core", name: "jackson-databind", version: "2.5.+") | ||
| compile(group: "commons-io", name: "commons-io", version: "2.4") | ||
| compile ("com.fasterxml.jackson.datatype:jackson-datatype-jsr310:2.5.1") |
There was a problem hiding this comment.
could you change this to use the same form as the other deps in this file?
|
I am not sure how everything came together, but this is broken, as per test But the issue is this: field It would probably be cleaner to actually register |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.