Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does not transform private fields declared in constructor #10

Closed
janousek opened this issue Aug 13, 2019 · 2 comments · Fixed by #11
Closed

Does not transform private fields declared in constructor #10

janousek opened this issue Aug 13, 2019 · 2 comments · Fixed by #11
Labels
bug Something isn't working

Comments

@janousek
Copy link

This simple case does not transform:

class Test {
    constructor(private tmp: any) { }
    public get() { return this.tmp; }
}
@timocov timocov added the bug Something isn't working label Aug 13, 2019
@timocov
Copy link
Owner

timocov commented Aug 13, 2019

Heh, nice catch. If you wish you can provide a PR with the fix. If not, then I'll see into it in couple of days.

timocov added a commit that referenced this issue Aug 15, 2019
@timocov
Added handling constructor parameters (#10)
182d557
@timocov timocov mentioned this issue Aug 15, 2019
Merged
@timocov
Copy link
Owner

timocov commented Aug 15, 2019

Version 0.2.0 is just published!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added handling constructor parameters timocov/ts-transformer-minify-privates
2 participants
@janousek @timocov