Skip to content
This repository has been archived by the owner on Sep 3, 2021. It is now read-only.

$(form).values() doesn't support multiple select #55

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

$(form).values() doesn't support multiple select #55

wants to merge 1 commit into from

Conversation

mudhairless
Copy link

The documentation for the values function says if there are multiple results for a name it will return an array and that seems to work for checkboxen and the like but not for selects. I have confirmed this in IE7+ and A grade browsers.

@timjansen
Copy link
Owner

Thank you for your patch. I am not sure yet how to go on with this issue as
well as some other smaller issues that have been discovered in 1.0, as
fixing them will break the 4kb barrier.

I am not applying your patch yet as I think there is likely a more compact
solution. Nia already supports multi-options, and it's implemented like
this:
if (el.multiple)
return $('option', el, true).collect(function(option) { if
(option.selected) return option.value; });

As there are several things like this, I hope to start working on 1.1 in
the next days.

Thanks,
Tim

On Sun, May 24, 2015 at 8:23 PM, Ebben Feagan notifications@github.com
wrote:

The documentation for the values function says if there are multiple
results for a name it will return an array and that seems to work for
checkboxen and the like but not for selects. I have confirmed this in IE7+

and A grade browsers.

You can view, comment on, or merge this pull request online at:

#55
Commit Summary

  • $(form).values() doesn't support multiple select

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#55.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants