Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return the gtk eventloop to previous state after pause #191

Merged
merged 2 commits into from
Jan 17, 2022

Conversation

IanButterworth
Copy link
Collaborator

@IanButterworth IanButterworth commented Jan 17, 2022

Currently if a window was already open and an error threw, the other window was left frozen because the error prevented the show being called and re-starting the event loop.

This fixes that to restore the event loop state after a pause

I upstreamed the pause function JuliaGraphics/Gtk.jl#613

@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #191 (3ad5d85) into master (ad912f3) will increase coverage by 0.25%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #191      +/-   ##
==========================================
+ Coverage   78.43%   78.68%   +0.25%     
==========================================
  Files           2        2              
  Lines         255      258       +3     
==========================================
+ Hits          200      203       +3     
  Misses         55       55              
Impacted Files Coverage Δ
src/ProfileView.jl 84.93% <100.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad912f3...3ad5d85. Read the comment docs.

@IanButterworth IanButterworth merged commit 67af946 into timholy:master Jan 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant