fixup call to Base.parse_cache_header for v1.11
#18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatteneder
changed the title
parse_cache_header for v1.11Base.parse_cache_header for v1.11
|
Normally we do a version check. So as soon as your code landed on master we can do |
fatteneder
force-pushed
the
fa/prepare-v1.11
branch
from
39f92de to
458c902
Compare
|
Ok. Fixed that. But will need to update version number once the other PR is merged. |
fatteneder
force-pushed
the
fa/prepare-v1.11
branch
from
458c902 to
4d155c7
Compare
fatteneder
force-pushed
the
fa/prepare-v1.11
branch
from
4d155c7 to
c1608d7
Compare
vchuravy
approved these changes
Nov 21, 2023
|
Thanks! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with
Julia v1.11we need to hand the file path toBase.parse_cache_headerin order to get sensible debug messages. (xref JuliaLang/julia#49866)Q: Is it ok to bump the compat entry here or should this be done together with a version bump?