Added yiq-is-light function, refactored yiq-contrast-color to take advantage #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timhettler
added a commit
that referenced
this pull request
Oct 31, 2013
Added yiq-is-light function, refactored yiq-contrast-color to take advantage
|
This is great, thanks dude! |
|
Very welcome! I'm teaching a zero to hero Sass+Compass training next week and am using this as an example of a Compass extension for everyone to work with. It's fantastic. |
|
❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It'd be really nice if we could determine if the color is light or not without needing to call
yiq-contrast-colorand comparing it to the color variable names. So, in that vein, I added ayiq-is-lightfunction that simply returnstrueorfalsebased on color and threshold input. Also refactoredyiq-contrast-colorto take advantage of the new function.