Check that no new internal program errors are introduced in CI #7863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Flaky Check specifically. The internal program errors (XX000) are reserved for bugs, we shouldn't encounter them during normal operation. We already have some places where this code is used incorrectly, so only check it for the newly introduced tests.
antekresic
approved these changes
Mar 20, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7863 +/- ##
==========================================
+ Coverage 80.06% 81.92% +1.86%
==========================================
Files 190 249 +59
Lines 37181 45994 +8813
Branches 9450 11517 +2067
==========================================
+ Hits 29770 37682 +7912
- Misses 2997 3776 +779
- Partials 4414 4536 +122 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
svenklemm
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Flaky Check specifically. The internal program errors (XX000) are reserved for bugs, we shouldn't encounter them during normal operation. We already have some places where this code is used incorrectly, so only check it for the newly introduced tests.
Disable-check: force-changelog-file