Use timer mock on Incremental CAgg Refresh policy tests #7813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7813 +/- ##
==========================================
+ Coverage 80.06% 81.95% +1.88%
==========================================
Files 190 248 +58
Lines 37181 45781 +8600
Branches 9450 11466 +2016
==========================================
+ Hits 29770 37521 +7751
- Misses 2997 3750 +753
- Partials 4414 4510 +96 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
akuzm
approved these changes
Mar 11, 2025
akuzm
added
the
force-auto-backport
github-actions bot
pushed a commit
that referenced
this pull request
Mar 12, 2025
(cherry picked from commit a4c57fe)
| @@ -531,6 +531,7 @@ FROM | |||
| '2025-03-11 00:00:00+00'::timestamptz, | |||
| '1 hour'::interval) AS t, | |||
| generate_series(1,5) AS d; | |||
| SET timescaledb.current_timestamp_mock TO '2025-03-11 00:00:00+00'; | |||
There was a problem hiding this comment.
Does timer mock support time zones i.e. is it set to a particular time zone?
There was a problem hiding this comment.
Yes it support ... it just return a TimestampTz. We do something like this in our code base:
#ifdef TS_DEBUG
Datum res = ts_get_mock_time_or_current_time();
#else
Datum res = TimestampTzGetDatum(GetCurrentTimestamp());
#endifIt means that will return the mock time if you set it, if you don't set a mock timestamp then ts_get_mock_timr_or_current_time() will return GetCurrentTimestamp().
There was a problem hiding this comment.
But will the test interpret, say, 2025-03-11 00:00:00+00 timer mock as being in a particular time zone? I.e. will it translate to local time if run, say, in New York vs. Berlin? Is the time zone hard set in the timer mock?
fabriziomello
added a commit
to fabriziomello/timescaledb
that referenced
this pull request
Mar 13, 2025
The usage of timer mock was wrong because we're setting it on the current session but the job is executed by a background worker that don't have the mock time configured. Fixed it by creating a user with an specific timezone and time mock configured so any background worker created by the user will have the proper configuration. Failed attempts to fix timescale#7813 and timescale#7819.
fabriziomello
added a commit
to fabriziomello/timescaledb
that referenced
this pull request
Mar 13, 2025
The usage of timer mock was wrong because we're setting it on the current session but the job is executed by a background worker that don't have the mock time configured. Fixed it by creating a user with an specific timezone and time mock configured so any background worker created by the user will have the proper configuration. Failed attempts to fix timescale#7813 and timescale#7819.
fabriziomello
added a commit
to fabriziomello/timescaledb
that referenced
this pull request
Mar 13, 2025
The usage of timer mock was wrong because we're setting it on the current session but the job is executed by a background worker that don't have the mock time configured. Fixed it by creating a user with an specific timezone and time mock configured so any background worker created by the user will have the proper configuration. Failed attempts to fix timescale#7813 and timescale#7819.
antekresic
pushed a commit
that referenced
this pull request
Mar 14, 2025
The usage of timer mock was wrong because we're setting it on the current session but the job is executed by a background worker that don't have the mock time configured. Fixed it by creating a user with an specific timezone and time mock configured so any background worker created by the user will have the proper configuration. Failed attempts to fix #7813 and #7819.
github-actions bot
pushed a commit
that referenced
this pull request
Mar 14, 2025
The usage of timer mock was wrong because we're setting it on the current session but the job is executed by a background worker that don't have the mock time configured. Fixed it by creating a user with an specific timezone and time mock configured so any background worker created by the user will have the proper configuration. Failed attempts to fix #7813 and #7819. (cherry picked from commit adfda01)
timescale-automation
pushed a commit
that referenced
this pull request
Mar 14, 2025
The usage of timer mock was wrong because we're setting it on the current session but the job is executed by a background worker that don't have the mock time configured. Fixed it by creating a user with an specific timezone and time mock configured so any background worker created by the user will have the proper configuration. Failed attempts to fix #7813 and #7819. (cherry picked from commit adfda01)
akuzm
pushed a commit
that referenced
this pull request
Mar 14, 2025
This is an automated backport of #7813: Use timer mock on Incremental CAgg Refresh policy tests. This PR will be merged automatically after all the relevant CI checks pass. If this fix should not be backported, or will be backported manually, just close this PR. You can use the backport branch to add your changes, it won't be modified automatically anymore. For more details, please see the [documentation](https://github.com/timescale/eng-database/wiki/Releasing-TimescaleDB#automated-cherry-picking-of-bug-fixes) ## Original description ### Use timer mock on Incremental CAgg Refresh policy tests Disable-check: force-changelog-file Disable-check: approval-count Co-authored-by: Fabrízio de Royes Mello <fabriziomello@gmail.com>
|
Automated backport to 2.19.x not done: cherry-pick failed. Git status |
timescale-automation
added
the
auto-backport-not-done
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disable-check: force-changelog-file
Disable-check: approval-count