Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle DEFAULT table access name in ALTER TABLE #7799

Merged
merged 1 commit into from
Mar 7, 2025

Conversation

mkindahl
Copy link
Contributor

@mkindahl mkindahl commented Mar 7, 2025

If ALTER TABLE ... SET ACCESS METHOD DEFAULT is used, the name of the table access method is NULL in the AlterTableCmd, so add checks that the name is not null before using it.

Function hypercore_alter_access_method_finish expects a chunk, but could be called with a non-chunk, so checking that the relid is a chunk before calling it.

@mkindahl mkindahl linked an issue Mar 7, 2025 that may be closed by this pull request
@mkindahl mkindahl force-pushed the fix-set-access-method branch from d86ef84 to 600e8ba Compare March 7, 2025 13:48
@mkindahl mkindahl requested review from erimatnor and antekresic March 7, 2025 13:49
Copy link

codecov bot commented Mar 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.85%. Comparing base (59f50f2) to head (53d1bb0).
Report is 806 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7799      +/-   ##
==========================================
+ Coverage   80.06%   81.85%   +1.78%     
==========================================
  Files         190      247      +57     
  Lines       37181    45462    +8281     
  Branches     9450    11371    +1921     
==========================================
+ Hits        29770    37212    +7442     
- Misses       2997     3766     +769     
- Partials     4414     4484      +70     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mkindahl mkindahl force-pushed the fix-set-access-method branch 2 times, most recently from f554dad to 7f2f715 Compare March 7, 2025 14:12
@mkindahl mkindahl marked this pull request as ready for review March 7, 2025 14:18
@mkindahl mkindahl force-pushed the fix-set-access-method branch from 7f2f715 to 785cfe2 Compare March 7, 2025 14:39
@mkindahl mkindahl added this to the v2.19.0 milestone Mar 7, 2025
@mkindahl mkindahl added bug ddl Issues that involve DDL handling table-access-method labels Mar 7, 2025
@mkindahl mkindahl enabled auto-merge (rebase) March 7, 2025 15:03
Copy link
Contributor

@erimatnor erimatnor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving, although I think you can make one small change to improve.

@mkindahl mkindahl disabled auto-merge March 7, 2025 16:54
@mkindahl mkindahl force-pushed the fix-set-access-method branch from 785cfe2 to e15236b Compare March 7, 2025 17:01
@mkindahl mkindahl enabled auto-merge (rebase) March 7, 2025 17:01
If `ALTER TABLE ... SET ACCESS METHOD DEFAULT` is used, the name of the
table access method is NULL in the `AlterTableCmd`, so add checks that
the name is not null before using it.

Function `hypercore_alter_access_method_finish` expects a chunk, but
could be called with a non-chunk, so checking that the relid is a
chunk.
@mkindahl mkindahl force-pushed the fix-set-access-method branch from e15236b to 53d1bb0 Compare March 7, 2025 21:17
@mkindahl mkindahl merged commit 32ec872 into timescale:main Mar 7, 2025
48 checks passed
@timescale-automation
Copy link
Member

Automated backport to 2.18.x not done: cherry-pick failed.

Git status

HEAD detached at origin/2.18.x
You are currently cherry-picking commit 32ec872d5.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   .unreleased/pr_7799
	modified:   src/process_utility.c
	new file:   test/expected/tableam_alter_defaults.out
	modified:   test/sql/CMakeLists.txt
	new file:   test/sql/tableam_alter_defaults.sql
	modified:   tsl/src/process_utility.c

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   tsl/src/hypercore/hypercore_handler.c


Job log

@timescale-automation timescale-automation added the auto-backport-not-done Automated backport of this PR has failed non-retriably (e.g. conflicts) label Mar 7, 2025
@mkindahl mkindahl deleted the fix-set-access-method branch March 8, 2025 08:54
philkra added a commit that referenced this pull request Mar 12, 2025
## 2.19.0 (2025-03-12)

This release contains performance improvements and bug fixes since 
the 2.18.2 release. We recommend that you upgrade at the next 
available opportunity.

**Features**
* [#7586](#7586) Vectorized aggregation with grouping by a single text column.
* [#7632](#7632) Optimize recompression for chunks without segmentby
* [#7655](#7655) Support vectorized aggregation on Hypercore TAM
* [#7669](#7669) Add support for merging compressed chunks
* [#7701](#7701) Implement a custom compression algorithm for bool columns. It is experimental and can undergo backwards-incompatible changes. For testing, enable it using timescaledb.enable_bool_compression = on.
* [#7707](#7707) Support ALTER COLUMN SET NOT NULL on compressed chunks
* [#7765](#7765) Allow tsdb as alias for timescaledb in WITH and SET clauses
* [#7786](#7786) Show warning for inefficient compress_chunk_time_interval configuration
* [#7788](#7788) Add callback to mem_guard for background workers
* [#7789](#7789) Do not recompress segmentwise when default order by is empty
* [#7790](#7790) Add configurable Incremental CAgg Refresh Policy

**Bugfixes**
* [#7665](#7665) Block merging of frozen chunks
* [#7673](#7673) Don't abort additional INSERTs when hitting first conflict
* [#7714](#7714) Fixes a wrong result when compressed NULL values were confused with default values. This happened in very special circumstances with alter table added a new column with a default value, an update and compression in a very particular order.
* [#7747](#7747) Block TAM rewrites with incompatible GUC setting
* [#7748](#7748) Crash in the segmentwise recompression
* [#7764](#7764) Fix compression settings handling in Hypercore TAM
* [#7768](#7768) Remove costing index scan of hypertable parent
* [#7799](#7799) Handle DEFAULT table access name in ALTER TABLE

**Thanks**
* @bjornuppeke for reporting a problem with INSERT INTO ... ON CONFLICT DO NOTHING on compressed chunks
* @kav23alex for reporting a segmentation fault on ALTER TABLE with DEFAULT

Signed-off-by: Philip Krauss <35487337+philkra@users.noreply.github.com>
This was referenced Mar 12, 2025
philkra added a commit that referenced this pull request Mar 18, 2025
## 2.19.0 (2025-03-18)

This release contains performance improvements and bug fixes since the
2.18.2 release. We recommend that you upgrade at the next available
opportunity.

* Improved concurrency of INSERT, UPDATE and DELETE operations on the
columnstore by no longer blocking DML statements during the
recompression of a chunk.
* Improved system performance during Continuous Aggregates refreshes by
breaking them into smaller batches which reduces systems pressure and
minimizes the risk of spilling to disk.
* Faster and more up-to-date results for queries against Continuous
Aggregates by materializing the most recent data first (vs old data
first in prior versions).
* Faster analytical queries with SIMD vectorization of aggregations over
text columns and group by over multiple column
* Enable optimizing chunk size for faster query performance on the
columnstore by adding support for merging columnstore chunks to the
merge_chunk API.

**Deprecation warning**

This is the last minor release supporting PostgreSQL 14. Starting with
the minor version of TimescaleDB only Postgres 15, 16 and 17 will be
supported.

**Downgrading of 2.19.0**

This release introduces custom bool compression, if you enable this
feature via the `enable_bool_compression` and must downgrade to a
previous, please use the [following
script](https://github.com/timescale/timescaledb-extras/blob/master/utils/2.19.0-downgrade_new_compression_algorithms.sql)
to convert the columns back to their previous state. TimescaleDB
versions prior to 2.19.0 do not know how to handle this new type.

**Features**
* [#7586](#7586) Vectorized
aggregation with grouping by a single text column.
* [#7632](#7632) Optimize
recompression for chunks without segmentby
* [#7655](#7655) Support
vectorized aggregation on Hypercore TAM
* [#7669](#7669) Add
support for merging compressed chunks
* [#7701](#7701) Implement
a custom compression algorithm for bool columns. It is experimental and
can undergo backwards-incompatible changes. For testing, enable it using
timescaledb.enable_bool_compression = on.
* [#7707](#7707) Support
ALTER COLUMN SET NOT NULL on compressed chunks
* [#7765](#7765) Allow tsdb
as alias for timescaledb in WITH and SET clauses
* [#7786](#7786) Show
warning for inefficient compress_chunk_time_interval configuration
* [#7788](#7788) Add
callback to mem_guard for background workers
* [#7789](#7789) Do not
recompress segmentwise when default order by is empty
* [#7790](#7790) Add
configurable Incremental CAgg Refresh Policy

**Bugfixes**
* [#7665](#7665) Block
merging of frozen chunks
* [#7673](#7673) Don't
abort additional INSERTs when hitting first conflict
* [#7714](#7714) Fixes a
wrong result when compressed NULL values were confused with default
values. This happened in very special circumstances with alter table
added a new column with a default value, an update and compression in a
very particular order.
* [#7747](#7747) Block TAM
rewrites with incompatible GUC setting
* [#7748](#7748) Crash in
the segmentwise recompression
* [#7764](#7764) Fix
compression settings handling in Hypercore TAM
* [#7768](#7768) Remove
costing index scan of hypertable parent
* [#7799](#7799) Handle
DEFAULT table access name in ALTER TABLE

**GUCs**
* `enable_bool_compression`: enable the BOOL compression algorithm,
default: `OFF`
* `enable_exclusive_locking_recompression`: enable exclusive locking
during recompression (legacy mode), default: `OFF`

**Thanks**
* @bjornuppeke for reporting a problem with INSERT INTO ... ON CONFLICT
DO NOTHING on compressed chunks
* @kav23alex for reporting a segmentation fault on ALTER TABLE with
DEFAULT

---------

Signed-off-by: Philip Krauss <35487337+philkra@users.noreply.github.com>
Signed-off-by: Ramon Guiu <ramon@timescale.com>
Co-authored-by: Ramon Guiu <ramon@timescale.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport-not-done Automated backport of this PR has failed non-retriably (e.g. conflicts) bug ddl Issues that involve DDL handling table-access-method
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Segmentation fault on SET ACCESS METHOD DEFAULT
4 participants