Fix default collation deserialization #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLockerman
force-pushed
the
jl/collation-serialization-fix
branch
from
f57b563 to
76ade21
Compare
JLockerman
changed the title
WireBaron
approved these changes
Jun 7, 2022
JLockerman
force-pushed
the
jl/collation-serialization-fix
branch
2 times, most recently
from
5d9c14e to
0650e50
Compare
JLockerman
force-pushed
the
jl/collation-serialization-fix
branch
from
0650e50 to
8a4ec73
Compare
We've run into an issue where the database default collation doesn't necessarily exist as a "real" collation in pg_collation. This code specializes the deserialization code to handle this: if we don't find the collation we're trying to deserialize, check if the name matches that of the default collation and if so assume it's the default collation.
JLockerman
force-pushed
the
jl/collation-serialization-fix
branch
from
8a4ec73 to
6a2f598
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've run into an issue where the database default collation doesn't necessarily exist as a "real" collation in pg_collation. This code specializes the deserialization code to handle this: if we don't find the collation we're trying to deserialize, check if the name matches that of the default collation and if so assume it's the default collation.
fixes #443