Skip to content

Commit

Permalink
Merge #509
Browse files Browse the repository at this point in the history
509: Fix typos and possibly a bug? r=WireBaron a=BenSandeen

Fix a typo in comments, fix some whitespace, and possibly fix a bug??

I haven't been able to get the tests running, so I'm sorry if this fails tests

This is an attempt to resolve this issue: #508

Co-authored-by: BenSandeen <12025856+BenSandeen@users.noreply.github.com>
  • Loading branch information
bors[bot] and BenSandeen authored Sep 6, 2022
2 parents 2eb84f0 + 2f24985 commit 9a4bf31
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion crates/hyperloglog/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ where
/// Creates a new, empty HyperLogLog.
///
/// - `b` number of bits used for register selection, number of registers within the
/// HyperLogLog will be `2^b`. `b` must be in `[4, 16]`
/// HyperLogLog will be `2^b`. `b` must be in `[4, 18]`
///
/// Panics when `b` is out of bounds.
pub fn new(b: usize) -> Self {
Expand Down
4 changes: 2 additions & 2 deletions crates/hyperloglogplusplus/src/dense.rs
Original file line number Diff line number Diff line change
Expand Up @@ -194,8 +194,8 @@ impl<'s> Storage<'s> {
(idx, right_delta)
} else {
let idx = *l;
if *r > 0 {
*r -= 1;
if *l > 0 {
*l -= 1;
return (idx, left_delta);
}
*self = Right(*r);
Expand Down
2 changes: 1 addition & 1 deletion extension/src/hyperloglog.rs
Original file line number Diff line number Diff line change
Expand Up @@ -507,7 +507,7 @@ mod tests {
)
.first()
.get_one::<String>();

let expected = "(\
version:1,\
log:Sparse(\
Expand Down

0 comments on commit 9a4bf31

Please sign in to comment.