fix: make file extension guessing with uri query parameters #879
+15
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoya
temporarily deployed
to
internal-contributors
GitHub Actions
Inactive
smoya
commented
Oct 7, 2025
| parsed = urlparse(file_path) | ||
| except Exception: | ||
| return None | ||
| split = parsed.path.split(".") |
There was a problem hiding this comment.
As we use urlparse, this give us just the path without the query parameters.
smoya
force-pushed
the
smoya/fix-file-extension-guessing
branch
from
6b0d3ba to
cb1bdda
Compare
smoya
temporarily deployed
to
internal-contributors
GitHub Actions
Inactive
smoya
commented
Oct 7, 2025
| parsed = urlparse(file_path) | ||
| except Exception: | ||
| return None | ||
| split = parsed.path.split(".") |
There was a problem hiding this comment.
As we use urlparse, this give us just the path without the query parameters.
smoya
commented
Oct 7, 2025
|
|
||
| def guess_filetype(file_like: BytesIO, file_path: str | None = None) -> str | None: | ||
| guess = filetype.guess(file_like) # type: ignore | ||
| extension = filetype.guess_extension(file_like) # type: ignore |
There was a problem hiding this comment.
This is a simplification. Calling guess_extension calls guess internally and just returns the extension, which is all we need.
smoya
force-pushed
the
smoya/fix-file-extension-guessing
branch
from
cb1bdda to
b8a8e63
Compare
smoya
temporarily deployed
to
internal-contributors
GitHub Actions
Inactive
cevian
approved these changes
Oct 7, 2025
JamesGuthrie
reviewed
Oct 7, 2025
JamesGuthrie
reviewed
Oct 7, 2025
| parsed = urlparse(file_path) | ||
| except Exception: | ||
| return None | ||
| split = parsed.path.split(".") |
smoya
commented
Oct 7, 2025
|
|
||
| def guess_filetype(file_like: BytesIO, file_path: str | None = None) -> str | None: | ||
| guess = filetype.guess(file_like) # type: ignore | ||
| guess = filetype.guess(file_like) # type: ignore[reportUnknownArgumentType,reportUnknownMemberType] |
There was a problem hiding this comment.
This error wasn't popping previously but now it does. Im just skipping. Other solution would be to do explicit casts.
smoya
commented
Oct 7, 2025
| except Exception: | ||
| return None | ||
|
|
||
| return ext[1:].lower() if ext else None |
There was a problem hiding this comment.
Added the .lower() so we ensure always to go with lowercase extensions. Just for consistency.
JamesGuthrie
approved these changes
Oct 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.