Better SQLite Support #10
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gangtao
reviewed
Sep 9, 2025
| # Initialize metadata storage based on configuration | ||
| self.use_sqlite = METADATA_STORAGE == "sqlite" | ||
|
|
||
| if self.use_sqlite: |
Contributor
There was a problem hiding this comment.
this code should be moved into method _init_pipeline_metadata
gangtao
reviewed
Sep 9, 2025
| raise | ||
| else: | ||
| # Initialize mutable stream for metadata (legacy mode) | ||
| self.pipeline_stream_name = "synthetic_data_pipelines" |
Contributor
There was a problem hiding this comment.
why both setting will use sqlite for metadata, seems the mutable stream based metadata is not here?
gangtao
reviewed
Sep 9, 2025
|
|
||
| db_logger.info(f"Successfully retrieved pipeline: {pipeline_info['name']} (writes: {live_count})") | ||
| return pipeline_info | ||
| if self.use_sqlite: |
Contributor
There was a problem hiding this comment.
this logic should be wrapper in the metadata manager
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To switch in Powershell:
$env:METADATA_STORAGE = "sqlite"
python main.py
$env:METADATA_STORAGE = "mutable_stream"
python main.py
To switch in zsh:
export METADATA_STORAGE=mutable_stream
python main.py
export METADATA_STORAGE=sqlite
python main.py