Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update init process for coinbase demo #511

Merged
merged 2 commits into from
Jan 20, 2024
Merged

update init process for coinbase demo #511

merged 2 commits into from
Jan 20, 2024

Conversation

gangtao
Copy link
Contributor

@gangtao gangtao commented Jan 20, 2024

make the demo simple to run by

  1. moving DDL to proton init process
  2. create pipeline with a init container

@gangtao gangtao added the enhancement New feature or request label Jan 20, 2024
@gangtao gangtao requested a review from jovezhong January 20, 2024 02:46
@gangtao gangtao self-assigned this Jan 20, 2024
jovezhong
jovezhong approved these changes Jan 20, 2024
View reviewed changes
Copy link
Contributor

@jovezhong jovezhong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I also updated sensor logger and hackernews dockercompose with this PR

@jovezhong jovezhong force-pushed the feature/improve-coinbase-example branch from 3b952ec to 0a274b5 Compare January 20, 2024 05:41
@jovezhong jovezhong merged commit 8c9e0c5 into develop Jan 20, 2024
1 check passed
@jovezhong
Copy link
Contributor

(Jove Github Bot) added it to the current sprint.

@jovezhong jovezhong deleted the feature/improve-coinbase-example branch February 23, 2024 02:29
@jovezhong
Copy link
Contributor

(Jove Github Bot) moved this ticket out of the GitHub project(up to 1200 tickets for one project).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jovezhong jovezhong jovezhong approved these changes

Assignees

@gangtao gangtao

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gangtao @jovezhong