Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve roshambo demo code: features calculated in Sklearn estimator … #10

Merged
merged 1 commit into from
Oct 17, 2022
Merged

Improve roshambo demo code: features calculated in Sklearn estimator … #10

merged 1 commit into from
Oct 17, 2022
+133 −219

Conversation

bertrandlalo
Copy link
Member

…instead of node

@bertrandlalo
Copy link
Member Author

Resolves issue issue #8

mesca
mesca requested changes Oct 17, 2022
View reviewed changes
Copy link
Member

@mesca mesca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you just move the transformer in an estimators folder to follow Timeflux convention?

@bertrandlalo bertrandlalo force-pushed the roshambo-features-estimator branch from bc15d15 to fb661b4 Compare October 17, 2022 13:31
@bertrandlalo bertrandlalo requested a review from mesca October 17, 2022 13:31
@mesca mesca merged commit fb8c691 into timeflux:main Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mesca mesca mesca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bertrandlalo @mesca