Add a filename to the define call in the module header#383
Open
dhill-rmn wants to merge 2 commits intotimdown:masterfrom
dhill-rmn:master
Open
Add a filename to the define call in the module header#383dhill-rmn wants to merge 2 commits intotimdown:masterfrom dhill-rmn:master
dhill-rmn wants to merge 2 commits intotimdown:masterfrom
dhill-rmn:master
Conversation
Fixes amd warnings: `Error: A module must not have more than one anonymous 'define' calls.` when adding dependency of `dist/wysihtml-toolbar` with r.js
Author
|
I hope that adding a named module does not cause any other issues? I shouldn't think so but naming the modules allows me to use r.js or any other amd optimizer to satisfy dependencies. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes amd warnings:
Error: A module must not have more than one anonymous 'define' calls.when adding dependency ofdist/wysihtml-toolbarwith r.js