Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for a field-separator argument #20

Closed
peterjanes opened this issue Apr 18, 2024 · 2 comments
Closed

Request for a field-separator argument #20

peterjanes opened this issue Apr 18, 2024 · 2 comments

Comments

@peterjanes
Copy link

Per #14, "if someone later wants a field-separator argument, make an issue for that."

My particular use case is dealing with large NDJSON streams, where it would be useful to be able to set a field-separator of ,. (There might be cases where a , is found within a key or value, but I don't know if multi-character delimiters is a legit request.)

@timbray
Copy link
Owner

timbray commented Apr 18, 2024

I think it'd be a dead easy PR, use Regexp.Split, and then some changes to config.c and runner.c for the new argument. But, the performance is going to take a pretty severe hit compared to the brute-force state machine in keyfinder.go - that should be measured and documented.

timbray added a commit that referenced this issue Apr 22, 2024
addresses #20

Signed-off-by: Tim Bray <tbray@textuality.com>
timbray added a commit that referenced this issue Apr 23, 2024
addresses #20

Signed-off-by: Tim Bray <tbray@textuality.com>
timbray added a commit that referenced this issue Apr 23, 2024
addresses #20

Signed-off-by: Tim Bray <tbray@textuality.com>
@timbray
Copy link
Owner

timbray commented Apr 25, 2024

Addressed in #23

@timbray timbray closed this as completed Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants