using proper scope for createTimeout #85
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using proper scope to prevent errors with external bundlers
|
I ran into the same problem. This fix worked for me. |
|
@tim-kos can you please take a look at this. Hope this can be merged into the repository. |
moshthepitt
added a commit
to nova-launch/withdraw-royalties
that referenced
this pull request
Apr 28, 2022
This commit simply ensures that "this.createTimeout" is replaced by "exports.createTimeout" in the node-retry package. This is so that we implement this PR: tim-kos/node-retry#85 before node-retry is officially updated.
|
@tim-kos Maybe, if you see this, could you please merge? Thank you! |
|
Same exact issue here. The code isn't technically wrong, but it's a rare pattern that some bundlers don't account for when trying to optimize modules. Please merge this soon because it's equivalent but more compatible. For anyone looking for an immediate, albeit non-optimal solution: parcel build --no-scope-hoist |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using a proper scope to prevent errors with external bundlers
Why
I tried using node-retry with Parcel v2 it had a hard time finding the right module to map. Now when I ran the built code I got the following error:
Using
exports.*scope instead ofthis.*will prevent this error.