test #38
Open
test #38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y vararg String: 'String... tags'. Removed unnecessary methods without vararg tags argument. Changed signature of 'time' and 'recordExecutionTime' methods: timeInMs now is long. Removed explicit array creation in test case.
API improvements
- Add support for initialization-time constant tag list (similar use case to constant prefix). - Convert millisecond times to floating-point histogram type for compatibility with upstream semantics.
Simplify life-cycle management of NonBlockingStatsDClient by running send() in a daemon thread.
Merge pull request from @lexn82 setting the daemon flag for the NonBlockingStatsDClient thread.
- fit as many messages (that are in the queue) into the MTU as possible
- convert to NIO
In addition to any NIO improvements,
this will offer a performance improvement when the incoming message rate per the time it takes to call blockingSend() goes above one.
Add NonBlockingStatsDClientPerfTest to ensure no messages are lost in a concurrent environment.
performance improvements: squash messages, and NIO
references: statsd documentation – https://github.com/etsy/statsd/blob/master/docs/metric_types.md breakage from commit dcae – dcaed45#commitcomment-5832637
Restores the old behaviour to resolve the address at construction time and cache it for the lifetime of the client.
Externalise DNS resolution on the NonBlockingStatsDClient.
- added finalizers - replaced 'throws Exception' where possible - removes 'this.' where possible
See pull requests comment in #26 and https://github.com/matthewAURA/java-dogstatsd-client/pull/1
Wiring in a queueSize constructor parameter for NonBlockingStatsDClient.
Minor corrections on capitalization of Datadog
Minor corrections on capitalization of Datadog
Update maven repository link in README
Fix syntax errors in example code.
Update readme to direct folks to new merged repo
Update readme to direct folks to new merged repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
18 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test