Skip to content

cluster: determine age #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 20, 2020
Merged

cluster: determine age #8

merged 1 commit into from
Oct 20, 2020

Conversation

nicks
Copy link
Member

@nicks nicks commented Oct 20, 2020

Hello @nicks,

Please review the following commits I made in branch nicks/init:

b49d738 (2020-10-20 11:39:49 -0400)
cluster: determine age

7c0c844 (2020-10-20 10:25:25 -0400)
cluster: determine product from context
This is a straight port of Tilt's k8s.Env

Code review reminders, by giving a LGTM you attest that:

  • Commits are adequately tested
  • Code is easy to understand and conforms to style guides
  • Incomplete code is marked with TODOs
  • Code is suitably instrumented with logging and metrics

@nicks nicks merged commit 8e80f64 into main Oct 20, 2020
@nicks nicks deleted the nicks/init branch October 20, 2020 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant