Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return payload even if NOK is set in the frame header. #11

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dehanj
Copy link
Member

@dehanj dehanj commented Jun 28, 2024

Description

The idea is to return the payload to the client application, even if the NOK bit is set in the framing header. This would allow for the application to utilize this for more expressive error handling if they want to. In short, give more freedom to the application developer, but still within the realm of the framing protocol.

Fixes #10

Type of change

  • Feature (non breaking change which adds functionality)

Submission checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my changes
  • I have tested and verified my changes on target
  • My changes are well written and CI is passing
  • I have squashed my work to relevant commits and rebased on main for linear history
  • I have added a "Co-authored-by: x" if several people contributed, either pair programming or by squashing commits from different authors.
  • I have updated the documentation where relevant (readme, dev.tillitis.se etc.)
  • QEMU is updated to reflect changes

This is to let the application decide what to do, if the NOK bit is set
in the header, which tkeyclient cannot know.
@dehanj dehanj requested a review from mchack-work July 3, 2024 08:12
@dehanj dehanj marked this pull request as ready for review July 3, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Return the payload even if ResponseNotOKis set
1 participant