Skip to content

[HOTFIX ] Applied verifone fix from legacy version #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SloInfinity merged 1 commit into from
Oct 7, 2025
Merged

[HOTFIX ] Applied verifone fix from legacy version #48

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...plugins/verifone/src/main/java/de/tillhub/printengine/verifone/VerifonePrintController.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,9 +103,9 @@ internal class VerifonePrintController(
)

companion object {
private val VERIFONE_FEED_STRING = FeedString("<br /><br /><br /><br /><br />")
private val VERIFONE_FEED_STRING = FeedString("<br /><br />")
private val VERIFONE_FONT_SIZE = FontSize(20)
private val VERIFONE_QR_CODE_SIZE = QrCodeSize(420)
private val VERIFONE_BARCODE_SIZE = BarcodeSize(140, 435)
private val VERIFONE_BARCODE_SIZE = BarcodeSize(140, 420)
}
}
8 changes: 4 additions & 4 deletions ...ins/verifone/src/test/java/de/tillhub/printengine/verifone/VerifonePrintControllerTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ internal class VerifonePrintControllerTest :
printerController.start()

verify(ordering = Ordering.ORDERED) {
barcodeEncoder.encodeAsBitmap("barcode", BarcodeType.CODE_128, 435, 140)
barcodeEncoder.encodeAsBitmap("barcode", BarcodeType.CODE_128, 420, 140)
printManager.printString(any(), payload, Printer.PRINTER_NO_CUTTER_LINE_FEED)
}
}
Expand Down Expand Up @@ -175,7 +175,7 @@ internal class VerifonePrintControllerTest :
}

it("feedPaper") {
val payload = HtmlUtils.transformToHtml("<br /><br /><br /><br /><br />")
val payload = HtmlUtils.transformToHtml("<br /><br />")

printerController.feedPaper()
printerController.start()
Expand Down Expand Up @@ -207,7 +207,7 @@ internal class VerifonePrintControllerTest :
)
append(HtmlUtils.generateImageHtml(bitmap))
appendLine(HtmlUtils.monospaceText("end line", 20))
append("<br /><br /><br /><br /><br />")
append("<br /><br />")
}.toString(),
)

Expand Down Expand Up @@ -246,7 +246,7 @@ internal class VerifonePrintControllerTest :
)
append(HtmlUtils.generateImageHtml(bitmap))
appendLine(HtmlUtils.monospaceText("end line", 20))
append("<br /><br /><br /><br /><br />")
append("<br /><br />")
}.toString(),
)

Expand Down
2 changes: 1 addition & 1 deletion sample/src/androidMain/kotlin/de/tillhub/printengine/sample/PrinterServiceFactory.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ object PrinterServiceFactory {
): PrintService = when (PrinterManufacturer.get()) {
PrinterManufacturer.PAX -> PaxServiceProvider.build(context, barcode = barcode)
PrinterManufacturer.SUNMI -> SunmiServiceProvider.build(context)
PrinterManufacturer.VERIFONE -> VerifoneServiceProvider.build(context)
PrinterManufacturer.VERIFONE -> VerifoneServiceProvider.build(context, barcode = barcode)
PrinterManufacturer.UNKNOWN -> createExternalPrinterService(context, externalPrinter)
}

Expand Down