Repository navigation
Resolve bundle launcher tolerantly after extraction - #55
Open
Omarinho12345 wants to merge 1 commit into
Open
Omarinho12345 wants to merge 1 commit into
Omarinho12345 wants to merge 1 commit into
Conversation
A verified bundle can extract fine yet miss the expected launcher path, as in tiliondev#34. Search the extracted tree for the launcher name before failing, and list what extraction produced when nothing is found. Fixes tiliondev#34.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #34
On the reporter's machine a SHA-verified bundle extracts fine but the launcher is not at tilion-fortress/tilion, so every launch fails the same way after a full re-download. This resolves the launcher tolerantly: the expected path first, else a search of the extracted tree for the launcher filename, and only then an error that lists what extraction actually produced (the old message named only the missing path, which is why the report had nothing actionable).
The archive is also kept when resolution fails, so the layout can be inspected instead of downloaded again. Behavior is unchanged when the layout matches.
Tests: five new offline cases in sdk/python/tests/test_sdk.py using crafted tarballs and zips (expected layout, renamed top dir, missing launcher with contents listed, zip launcher, cached launcher with no network). Full file passes: 27 passed.