make every zoom's tile use 4096 as extent #404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iandees
reviewed
Dec 10, 2021
| quantize_bounds = kwargs['quantize_bounds'] | ||
| extent = int(round((quantize_bounds[2] - quantize_bounds[0]) / | ||
| resolution)) | ||
| # quantize_bounds = kwargs['quantize_bounds'] |
There was a problem hiding this comment.
Delete these instead of commenting?
There was a problem hiding this comment.
Delete these instead of commenting?
we hardcoded it to be 4096, but a better logic would be to use some of the commented out calculation; so maybe we should keep them? I added more comments/doc for this in the next commit.
|
In small sample tests this yields 4-5% file savings. |
tgrigsby-sc
reviewed
Dec 11, 2021
tilequeue/process.py
Outdated
| if cut_coord == coord: | ||
| # no need for cutting if this is the original tile. | ||
| tiles = _format_feature_layers( | ||
| processed_feature_layers, coord, nominal_zoom, formats, | ||
| unpadded_bounds, cut_scale, buffer_cfg) | ||
| unpadded_bounds, scale, buffer_cfg) |
There was a problem hiding this comment.
I think it's worth a comment that you're not using cut scale anymore
There was a problem hiding this comment.
I think it's worth a comment that you're not using cut scale anymore
added in the next commit
peitili
force-pushed
the
extentchange
branch
from
e0e29e2
to
297ac44
Compare
peitili
requested review from
iandees and
tgrigsby-sc
and removed request for
tgrigsby-sc
iandees
approved these changes
Dec 13, 2021
nvkelso
approved these changes
Dec 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scale used to be 8192 in some circumstances, but we think that's not necessary so we reduce it to 4096 for all zooms.
Test
Rebuilt England area using with the change and found all zooms extent are 4096 now.