Skip to content

Conversation

tgrigsby-sc
Copy link
Contributor

@tgrigsby-sc tgrigsby-sc commented Dec 3, 2021

In order to support overzooming, we leave features in tiles with zoom max_zoom_with_changes whose min_zoom is greater. This is fine, except, because of the nature of the way we build metatiles, we also include them in the size before that, which corresponds to zoom max_zoom_with_changes - 1. These features will never be used or needed in these tiles.

This change detects this scenario, we're building a coordinate that is below nominal_zoom AND nominal_zoom equals max_zoom_with_changes, and then removes the features we were only leaving in to support overzoom, which is anything where properties["min_zoom"] >= nominal_zoom +1

@tgrigsby-sc tgrigsby-sc changed the title [wip] [rfc] might work Trim overzoom contents from tiles where it's not needed Dec 9, 2021
@tgrigsby-sc tgrigsby-sc changed the title Trim overzoom contents from tiles where it's not needed Trim overzoom features from tiles where they're not needed Dec 9, 2021
@nvkelso
Copy link
Member

nvkelso commented Dec 10, 2021

Reviewing output MVTs this matches my expectations.

Copy link
Member

@iandees iandees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic makes sense 👍🏻 but the different zooms still confuse me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants