-
Notifications
You must be signed in to change notification settings - Fork 19
Trim overzoom features from tiles where they're not needed #402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
tgrigsby-sc
merged 17 commits into
master
from
travisg/20211202-remove-wrong-min_zoom-items-from-penultimate-zoom
Dec 11, 2021
Merged
Trim overzoom features from tiles where they're not needed #402
tgrigsby-sc
merged 17 commits into
master
from
travisg/20211202-remove-wrong-min_zoom-items-from-penultimate-zoom
Dec 11, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…move-wrong-min_zoom-items-from-penultimate-zoom
Reviewing output MVTs this matches my expectations. |
iandees
approved these changes
Dec 10, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic makes sense 👍🏻 but the different zooms still confuse me.
This was referenced Dec 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support overzooming, we leave features in tiles with zoom
max_zoom_with_changes
whose min_zoom is greater. This is fine, except, because of the nature of the way we build metatiles, we also include them in the size before that, which corresponds to zoommax_zoom_with_changes - 1
. These features will never be used or needed in these tiles.This change detects this scenario, we're building a coordinate that is below
nominal_zoom
ANDnominal_zoom
equalsmax_zoom_with_changes
, and then removes the features we were only leaving in to support overzoom, which is anything whereproperties["min_zoom"] >= nominal_zoom +1