Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix problems with disputed boundaries from RAWR tiles #380

Merged
merged 2 commits into from
May 23, 2019

Conversation

zerebubuth
Copy link
Member

Fixes build problems discovered during the v1.8d build:

  1. The code was dropping all linestrings. This used to be the correct behaviour, but now claims and disputes are included as line features and these should not be dropped any more.
  2. After converting from the polygon to the boundary, the mz_boundary_from_polygon flag was being set on the wrong set of properties. This caused a downstream process to explode, since the feature no longer matched any of the YAML rules.

1. The code was dropping all linestrings. This used to be the correct behaviour, but now claims and disputes are included as line features and these should not be dropped any more.
2. After converting from the polygon to the boundary, the `mz_boundary_from_polygon` flag was being set on the wrong set of properties. This caused a downstream process to explode, since the feature no longer matched any of the YAML rules.
@zerebubuth zerebubuth requested a review from nvkelso May 23, 2019 15:17
…nd claims) and should set a flag on polygons we converted to linestring boundaries.
Copy link
Member

@nvkelso nvkelso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zerebubuth zerebubuth merged commit 5534cc1 into master May 23, 2019
@zerebubuth zerebubuth deleted the zerebubuth/fix-boundary-from-poly-rawr branch August 1, 2019 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants