Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump PyPROJ version to 2.1.0, use new Transformer interface. #371

Merged
merged 3 commits into from
Mar 18, 2019

Conversation

zerebubuth
Copy link
Member

The internals of PyPROJ changed in v2 in a way that makes our calls to transform via Shapely's ops very slow, as PyPROJ is constantly setting up and tearing down intermediate objects. Since v2.1.0, there's a new Transformer interface which caches the intermediate objects, which is essentially the same speed as the old v1.9.5 version that we were using.

Since we don't need any of the new features of v2.1.0, it's tempting to just pin to the old version, however the reason I picked this up is because our tests in vector-datasource don't pin the PyPROJ version, and we ended up getting v2, making the tests about 20x slower. Adding a pin "fixes" this, but it seems like it'd be less confusing for people using the code if the version installed by pip install pyproj was OK.

@zerebubuth
Copy link
Member Author

PS: Unit tests weren't running for this repo, looks like we never upgraded from CircleCI 1.0 and that no longer runs. I added some changes to get this working with 2.0.

@zerebubuth zerebubuth requested a review from iandees March 18, 2019 11:02
@zerebubuth
Copy link
Member Author

PPS: This looks like it takes the vector-datasource CI run down from about 13-14 minutes down to 4. The time spent in the integration tests drops from 10 minutes to 40s.

Copy link
Member

@rmarianski rmarianski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zerebubuth zerebubuth merged commit 7101224 into master Mar 18, 2019
@zerebubuth zerebubuth deleted the zerebubuth/speed-up-circleci branch March 18, 2019 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants